Skip to content
Snippets Groups Projects

F release results

Merged F release results
f-release-results into dev
All threads resolved!
Merged Timm Fitschen requested to merge f-release-results into dev
All threads resolved!

Summary

Fixes SegFaults in the retrieve function (and others) which were caused by the too-early deletion of the transaction object by the garbage collector

Focus

The most relevant line is where we call caosdb_transaction_result_set_release_at instead of caosdb_transaction_result_set_at and release the entity from the result set.

Test Environment

Integration caosdb-juliainttest!7 (merged)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Pipeline #13369 passed

Stage: info
Stage: code-style
Stage: setup
Stage: test
Stage: deploy
Pipeline: CaosDB Julia Integration Tests

#13370

    Pipeline passed for c4dcd501 on f-release-results

    Approval is optional

    Merged by Florian SpreckelsenFlorian Spreckelsen 3 years ago (Sep 9, 2021 2:36pm UTC)

    Merge details

    • Changes merged into dev with a68b3dbb.
    • Deleted the source branch.

    Pipeline #13933 failed

    Stage: info
    Stage: code-style
    Stage: setup
    Stage: test
    Stage: deploy

    Pipeline failed for a68b3dbb on dev

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen requested review from @florian

    requested review from @florian

  • Timm Fitschen marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • Florian Spreckelsen mentioned in commit a68b3dbb

    mentioned in commit a68b3dbb

  • Florian Spreckelsen merged

    merged

  • Florian Spreckelsen mentioned in commit caosdb-juliainttest@1caeb4ec

    mentioned in commit caosdb-juliainttest@1caeb4ec

    • Please register or sign in to reply