Skip to content

Copy constructor for result set and entity

Timm Fitschen requested to merge f-copy-entity into dev

Summary

These changes support a better handling of the ResultSet and Entity objects when their owners are to be deleted (e.g. in clients which delete transansaction due to end of the scope of a function while they return an entity or the resultset of said transaction)

These changes are needed for caosdb-julialib!12 (merged)

The server is just being updated for version-compatibility reasons: caosdb-server!31 (merged)

Focus

  • Refactoring of the ResultSet and Entity class' copy constructors (amd a general clean-up of the Entity constructor)
  • Additional Transaction::ReleaseResultSet and ResultSet::release_at methods which release the unique_ptr from their owning objects.

Test Environment

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • [ ] Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • [ ] Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports