Skip to content
Snippets Groups Projects

Copy constructor for result set and entity

Merged Timm Fitschen requested to merge f-copy-entity into dev
All threads resolved!

Summary

These changes support a better handling of the ResultSet and Entity objects when their owners are to be deleted (e.g. in clients which delete transansaction due to end of the scope of a function while they return an entity or the resultset of said transaction)

These changes are needed for caosdb-julialib!12 (merged)

The server is just being updated for version-compatibility reasons: caosdb-server!31 (merged)

Focus

  • Refactoring of the ResultSet and Entity class' copy constructors (amd a general clean-up of the Entity constructor)
  • Additional Transaction::ReleaseResultSet and ResultSet::release_at methods which release the unique_ptr from their owning objects.

Test Environment

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • [ ] Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • [ ] Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen requested review from @florian

    requested review from @florian

  • mentioned in merge request caosdb-server!31 (merged)

  • Timm Fitschen added 2 commits

    added 2 commits

    • 9365fe65 - 1 commit from branch dev
    • 314bd34f - Merge branch 'dev' into f-copy-entity

    Compare with previous version

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • added 1 commit

    • b2c97e0a - DOC: Add remark on release functions to C-API documentation

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Florian Spreckelsen enabled an automatic merge when the pipeline for b2c97e0a succeeds

    enabled an automatic merge when the pipeline for b2c97e0a succeeds

  • mentioned in commit b756e4a9

  • Please register or sign in to reply
    Loading