Better error message

Summary

This very small MR just adds two more verbose error messages for two mistakes that can appear during cfood development.

Please see the in-code comments for details.

Test Environment

There are unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caoscrawler/converters/converters.py

@@ -288,6 +288,9 @@ def create_records(values: GeneralStore, records: RecordStore, def_records: dict
 
         c_record = records[name]
 
+        if isinstance(record, str):
+            raise RuntimeError(
+                "dict expected, but found str: {}".format(record))
         for key, value in record.items():
             if key == "parents" or key == "role":
                 continue
@@ -404,6 +407,10 @@ class Converter(object, metaclass=ABCMeta):
         The `type` key in the `definition` defines the Converter class which is being used.
         """
 
+        if definition is None:
+            raise RuntimeError("Definition of converter \"{}\" is "
+                               "empty".format(name))
+
         if "type" not in definition:
             raise RuntimeError(
                 "Type is mandatory for converter entries in CFood definition.")