Skip to content
Snippets Groups Projects

Better error message

Merged Alexander Schlemmer requested to merge f-better-error-message into dev

Summary

This very small MR just adds two more verbose error messages for two mistakes that can appear during cfood development.

Please see the in-code comments for details.

Test Environment

There are unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Schlemmer
  • Alexander Schlemmer changed title from Draft: F better error message to Draft: Better error message

    changed title from Draft: F better error message to Draft: Better error message

  • Alexander Schlemmer changed the description

    changed the description

  • added 4 commits

    • 4c7ef8cc - DOC: improved some documentation of scanner functions
    • f3011888 - TST: added failing test for error message check
    • ce4843f2 - TST: completed test for empty converter definitions
    • 7f645c74 - TST: added test for error message in case of broken record definition

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • mentioned in issue #173

  • Alexander Schlemmer changed the description

    changed the description

  • Alexander Schlemmer marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Alexander Schlemmer marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item Up-to-date JSON schema (or not necessary) as completed

    marked the checklist item Up-to-date JSON schema (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Alexander Schlemmer marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Alexander Schlemmer marked this merge request as ready

    marked this merge request as ready

  • added 1 commit

    Compare with previous version

  • added 20 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading