XML Converter
-
Review changes -
-
Download -
Patches
-
Plain diff
Summary
Base functionality for matching and converting XML trees is implemented.
See: #145 (closed)
This should be reviewed and merged relatively soon. Follow-up issues will be created for the following tasks:
-
user and API documentation (#159) -
design and implement more unit tests (#160) -
integration tests (#161) -
issue for creating attribute node converter and completing the text node converter (#158 (closed))
Focus
Have a look at #145 (closed) and check whether the requirements are met.
Test Environment
There are unit tests.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Alexander Schlemmer
Merge request reports
Compare and
- version 25dfe6082e
- version 24f25e21e7
- version 2352e21348
- version 223ec19b51
- version 21082bf849
- version 207f85b5e3
- version 193f57958e
- version 18e630637d
- version 17ac1bbf42
- version 16bb91f879
- version 15c4c7070c
- version 14ea2f1542
- version 1317c7eb7f
- version 123a9ca4f3
- version 113e8b13df
- version 1010df18a9
- version 9072bffdb
- version 83bb7861a
- version 7602132e7
- version 6616c2f8a
- version 58e9b6532
- version 40694462d
- version 3a6b41c7a
- version 2ec0d5c36
- version 1ec0d5c36
- dev (base)
- latest versioneeb78d2434 commits,
- version 25dfe6082e33 commits,
- version 24f25e21e732 commits,
- version 2352e2134831 commits,
- version 223ec19b5130 commits,
- version 21082bf84929 commits,
- version 207f85b5e328 commits,
- version 193f57958e26 commits,
- version 18e630637d25 commits,
- version 17ac1bbf4224 commits,
- version 16bb91f87923 commits,
- version 15c4c7070c22 commits,
- version 14ea2f154221 commits,
- version 1317c7eb7f18 commits,
- version 123a9ca4f317 commits,
- version 113e8b13df15 commits,
- version 1010df18a914 commits,
- version 9072bffdb13 commits,
- version 83bb7861a12 commits,
- version 7602132e710 commits,
- version 6616c2f8a9 commits,
- version 58e9b65328 commits,
- version 40694462d7 commits,
- version 3a6b41c7a6 commits,
- version 2ec0d5c362 commits,
- version 1ec0d5c362 commits,
Compare changes
- Side-by-side
- Inline
Files
21Loading