F fix misleading error

Summary

For #127 (closed). This just improves the original error message and does not introduce additional error handling.

Focus

Since it was highly non-trivial to introduce error handling that could actually distinguish between (cf. docstring of new test) not being able to merge b1 and b2 because of unresolvable merge conflicts in c1 and c2 and only having to postpone the merge because of apparent merge conflicts that will be resolved down the line, we do not introduce new error handling. Instead, we point out that the error with missing referencing identifiables might be due to merge conflicts in the referencing entities.

Test Environment

Unit test

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

unittests/test_crawler.py

@@ -405,7 +405,6 @@ def test_split_into_inserts_and_updates_with_copy_attr(crawler_mocked_identifiab
     crawler.identifiableAdapter.retrieve_identified_record_for_identifiable.assert_called()
 
 
-@pytest.mark.xfail(reason="https://gitlab.com/linkahead/linkahead-crawler/-/issues/88")
 @patch("caoscrawler.identifiable_adapters.cached_query",
        new=Mock(side_effect=mock_cached_only_rt))
 def test_split_iiau_with_unmergeable_list_items():
@@ -429,12 +428,16 @@ Identifiables
 
 id_A: [prop_ident]
 id_B: [prop_ident, "is_referenced_by: A"]
+id_C: [prop_other, "is_referenced_by: B"]
 
 Data
 ----
 
-b1: ("same", 23)
-b2: ("same", 42)
+c1: (23)
+c2: (42)
+
+b1: ("same", c1)
+b2: ("same", c2)
 
 a: ([b1, b2])
     """
@@ -469,18 +472,13 @@ a: ([b1, b2])
 
     crawler = Crawler(identifiableAdapter=ident_adapter)
 
-    # This should give a merge conflict, and not
-    # "Could not find referencing entities of type(s): A"
-
-    # from IPython import embed; embed()
     with raises(RuntimeError) as rte:
         crawler.synchronize(commit_changes=False,
                             crawled_data=[rec_a, *rec_b, *rec_c])
     assert not isinstance(rte.value, NotImplementedError), \
         "Exception must not be NotImplementedError, but plain RuntimeError."
-    assert "Could not find referencing entities" not in rte.value.args[0]
-    assert "merging impossible" in rte.something
-    # crawler.split_into_inserts_and_updates(ent_list=[rec_a, *rec_b, *rec_c])
+    assert "Could not find referencing entities" in rte.value.args[0]
+    assert "merge conflicts in the referencing" in rte.value.args[0]
 
 
 def test_has_missing_object_in_references():