F refactor test tool
Summary
- TODOs from #97 (closed)
- replaced repeated definitions of
rfp
with a globalUNITTESTDIR
Path
variable - replaced repeated and varying definitions of
dircheckstr
by a commonly used one
Focus
-
test_tool
was removed and the code was moved to other files. The diff is therefor hard to read. You might want to get the current version oftest_tool
usinggit co dev -- unittests/test_tool.py
(remember to delete the file again later) and compare it withunittests/test_crawler.py
andunittests/test_scanner.py
Note
- Please have a look at !114 (merged) . I merged the branch in here, because it is useful here. !114 (merged) could not be merged because of failing test, but with this refactoring the tests pass.
- There are more issues that consider other parts of necessary refactoring and there are TODOs in the code that reflect that
Test Environment
unit and integration tests
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Alexander Schlemmer