F retrieve identified

Summary

Minor change: The function retrieve_identified_record_for_record now only creates an identifiable if necessary, i.e. if no path and no ID is available.

Test Environment

unit and int test

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/85
• Up-to-date CHANGELOG.md (or not necessary) (internal change; there is no reason not to do this)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

assigned to @henrik

added 1 commit

• 438ef826 - wip

Compare with previous version

added 9 commits

• f0b194be - reactivate test
• e9d7673e - MAINT: replace custom implemenation with library get_entity_by
• adbb68a7 - MAINT: clear cache when necessary
• a078cea8 - DOC: add note on caching
• 8733473a - TST: clear caches in int tests
• bc504605 - Merge branch 'f-get-by' into f-retrieve-identified
• c6b70780 - use library function
• 96d80c6d - fix typo
• f0d04cc3 - Merge branch 'f-get-by' into f-retrieve-identified

Compare with previous version

added 5 commits

• d7369822 - fix typo
• 35ce1533 - fix usage of autouse
• 5dd2d105 - deal with nonexisting files
• 318194a7 - Merge branch 'f-get-by' into f-retrieve-identified
• 96ccbf95 - fix typo

Compare with previous version

added 7 commits

• e86bfedc - 1 commit from branch dev
• 6790903a - add mssing import
• 1af0ce52 - correct var name
• 2717f169 - fix
• 62bc81b8 - add missing import
• 51a58611 - Merge branch 'dev' into f-get-by
• 71c2a342 - Merge branch 'f-get-by' into f-retrieve-identified

Compare with previous version

changed target branch from dev to f-get-by

marked the checklist item Up-to-date JSON schema (or not necessary) as completed

marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

marked the checklist item Annotations in code (Gitlab comments) as completed

requested review from @florian

added 1 commit

• 150a254a - FIX: var name

Compare with previous version

deleted the f-get-by branch. This merge request now targets the dev branch

mentioned in merge request !113 (merged)

marked the checklist item I understand the intent of this MR as completed

resolved all threads

marked the checklist item In-code documentation and comments are up-to-date. as completed

marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

I actually quickly reviewed this one as part of !113 (merged) .

requested review from @salexan

approved this merge request

merged