Skip to content
Snippets Groups Projects
Commit 2c2d7119 authored by Alexander Schlemmer's avatar Alexander Schlemmer
Browse files

DOC: added a comment to child generation behavior in rocrate converter

parent 44eb46ec
No related branches found
No related tags found
2 merge requests!217TST: Make NamedTemporaryFiles Windows-compatible,!215Fix issues in rocrate support
Pipeline #60824 failed
......@@ -202,7 +202,6 @@ class ROCrateEntityConverter(Converter):
# is supposed to be dereferenced:
if not (len(value) == 1 and "@id" in value):
raise RuntimeError("The JSON-LD is not flat.")
# TODO: tests missing!
dereferenced = element.entity.crate.dereference(value["@id"])
if dereferenced is not None:
children.append(
......@@ -225,8 +224,6 @@ class ROCrateEntityConverter(Converter):
children.append(
ROCrateEntity(element.folder, element.entity.crate.dereference(
p["@id"])))
# TODO: it feels a bit strange to add (especially variableMeasured) directly, top-level
# and not in a sub-DictElement. The latter would be difficult to realize, because
# resolving the sub-references is not straight-forward.
# TODO: See https://gitlab.indiscale.com/caosdb/src/caosdb-crawler/-/issues/195 for discussion.
return children
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment