From 2c2d711943c258efd21f39ddd0f68e86235752c0 Mon Sep 17 00:00:00 2001
From: Alexander Schlemmer <a.schlemmer@indiscale.com>
Date: Thu, 13 Feb 2025 15:40:50 +0100
Subject: [PATCH] DOC: added a comment to child generation behavior in rocrate
converter
---
src/caoscrawler/converters/rocrate.py | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/caoscrawler/converters/rocrate.py b/src/caoscrawler/converters/rocrate.py
index f0140fa..7dcad86 100644
--- a/src/caoscrawler/converters/rocrate.py
+++ b/src/caoscrawler/converters/rocrate.py
@@ -202,7 +202,6 @@ class ROCrateEntityConverter(Converter):
# is supposed to be dereferenced:
if not (len(value) == 1 and "@id" in value):
raise RuntimeError("The JSON-LD is not flat.")
- # TODO: tests missing!
dereferenced = element.entity.crate.dereference(value["@id"])
if dereferenced is not None:
children.append(
@@ -225,8 +224,6 @@ class ROCrateEntityConverter(Converter):
children.append(
ROCrateEntity(element.folder, element.entity.crate.dereference(
p["@id"])))
- # TODO: it feels a bit strange to add (especially variableMeasured) directly, top-level
- # and not in a sub-DictElement. The latter would be difficult to realize, because
- # resolving the sub-references is not straight-forward.
+ # TODO: See https://gitlab.indiscale.com/caosdb/src/caosdb-crawler/-/issues/195 for discussion.
return children
--
GitLab