Skip to content
Snippets Groups Projects

ENH: Support FIND and COUNT queries

Merged ENH: Support FIND and COUNT queries
f-query into dev
1 unresolved thread
Merged Florian Spreckelsen requested to merge f-query into dev
1 unresolved thread

Summary

See https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/399. Introduces FIND and Count queries.

Focus

Most changes are in transaction.h and transaction.cpp.

Test Environment

Unit and integration tests with server in f-grpc-f-query

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • [ ] Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • [ ] Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
include/caosdb/transaction.h
383 411 MultiTransactionRequest *request;
384 412 mutable MultiTransactionResponse *response;
385 413 std::string error_message;
414 mutable long query_count;
  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • a7dd793e - TST: test for multi-deletion

    Compare with previous version

  • Florian Spreckelsen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen approved this merge request

    approved this merge request

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Florian Spreckelsen added 1 commit

    added 1 commit

    • c84a193c - MAINT: Make return of GetCountResult long

    Compare with previous version

  • Florian Spreckelsen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen merged

    merged

    • Please register or sign in to reply