Skip to content
Snippets Groups Projects

ENH: Values can hold empty vector

Merged Daniel Hornung requested to merge f-empty-vector into dev
All threads resolved!
1 file
+ 5
5
Compare changes
  • Side-by-side
  • Inline
+ 5
5
Daniel Hornung
Last comment by Daniel Hornung
@@ -37,8 +37,8 @@
this->wrapped->mutable_list_values()->add_values()->SETTER(value); \
} \
if (values.empty()) { \
this->wrapped->mutable_list_values()->add_values()->set_special_value \
(ProtoSpecialValue::SPECIAL_VALUE_UNSPECIFIED); \
this->wrapped->mutable_list_values()->add_values()->set_special_value( \
ProtoSpecialValue::SPECIAL_VALUE_UNSPECIFIED); \
} \
}
@@ -389,9 +389,9 @@ public:
return !IsNull() && this->wrapped->value_case() == ValueCase::kListValues;
}
[[nodiscard]] inline auto GetAsVector() const noexcept -> const std::vector<ScalarValue> & {
if (!IsVector() || (this->wrapped->list_values().values(0).has_special_value()
&& this->wrapped->list_values().values(0).special_value()
== ProtoSpecialValue::SPECIAL_VALUE_UNSPECIFIED)) {
if (!IsVector() || (this->wrapped->list_values().values(0).has_special_value() &&
this->wrapped->list_values().values(0).special_value() ==
ProtoSpecialValue::SPECIAL_VALUE_UNSPECIFIED)) {
// create empty list
static std::vector<ScalarValue> empty_values;
return empty_values;
Loading