Skip to content
Snippets Groups Projects

ENH: Values can hold empty vector

Merged Daniel Hornung requested to merge f-empty-vector into dev
All threads resolved!

Summary

Values should be able to hold empty vector. Before this MR, creating a value with an empty vector does not make this a vector.

See #76 (closed).

Focus

Nothing special.

Test Environment

Run the unit test.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Joscha Schmiedt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • requested review from @joschaschmiedt

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung added 2 commits

    added 2 commits

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 0d9d1352 - MAINT: Check for doxygen first.

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 8bfc898e - FIX: Formatting in documentation.

    Compare with previous version

  • Daniel Hornung
  • Daniel Hornung
  • Joscha Schmiedt marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Joscha Schmiedt marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Joscha Schmiedt marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Joscha Schmiedt resolved all threads

    resolved all threads

  • Joscha Schmiedt marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Joscha Schmiedt marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Joscha Schmiedt marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Joscha Schmiedt marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Looks all fine to me!

  • Joscha Schmiedt approved this merge request

    approved this merge request

  • Joscha Schmiedt mentioned in commit 1330c185

    mentioned in commit 1330c185

  • Please register or sign in to reply
    Loading