The new code mainly wraps the protobuf "SelectQueryResult" message and it's members. The pattern used for the new ResultTable class is a delegator pattern which makes it possible to hide third-party headers from our public API.
Unit tests would not help a lot anyways because we have mainly wrapper classes around the protobuf messages.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab
comments for the reviewer. They should guide the reviewer through the changes, explain your changes
and also point out open questions. For further good practices have a look at our review
guidelines
All automated tests pass (failures in downstream libraries - julia and octave - are not caused by these changes. They also happen in the dev branch)
Reference related issues
Up-to-date CHANGELOG.md (or not necessary)
Annotations in code (Gitlab comments)
Intent of new code
Problems with old code
Why this implementation?
Check List for the Reviewer
I understand the intent of this MR
All automated tests pass
Up-to-date CHANGELOG.md (or not necessary)
The test environment setup works and the intended behavior is reproducible in the test
environment
In-code documentation and comments are up-to-date.
Check: Are there specifications? Are they satisfied?
