F grpc select
Summary
- Implementation of
SELECTqueries for the GRPC API (https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/110) - (Re)fix of an undead server bug (https://gitlab.com/caosdb/caosdb-server/-/issues/136)
- Correction of a wrong implementation of
FINDqueries which was not recognized before. This will lead to the necessity to fix https://gitlab.indiscale.com/caosdb/customers/cfaed/complexitywiki/-/issues/1
Focus
Most of the code related to 1. is located in src/main/java/org/caosdb/server/grpc/EntityTransactionServiceImpl.java and src/main/java/org/caosdb/server/grpc/CaosDBToGrpcConverters.java.
Everything else is mostly general refactoring or fixing the mentioned issues 2. and 3.
Test Environment
No manual testing necessary.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
assigned to @timm
mentioned in merge request caosdb-cppinttest!27 (merged)
added 1 commit
- 7648d2a6 - MAINT: refactor retrieve function in EntityTransactionService
mentioned in merge request caosdb-pyinttest!46 (merged)
mentioned in merge request caosdb-proto!9 (merged)
