F cpp to string
All threads resolved!
All threads resolved!
Compare changes
Implements #23 (closed) and fixes #24 (closed)
The ProtoMessageWrapper has been refactored into an abstract base class for RepeatedPtrFieldWrapper and ScalarProtoMessageWrapper, which implement the ToString methods. Effectively this means that now Parent, Parents, Property, Properties, Message, Messages, DataType, Value, ScalarValue (and probably some more) classes have the ToString method.
The problem was that the Value's collection_value member has not been overridden, when the Value itself has been overridden.
This has been fixed by initializing a fresh instance of Value and by resetting the collection_value member in the assignment operators.
This problem most likely affected the DataType as well (and should be fixed by now).
Everything else is for #23 (closed).
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.