F cpp to string
Summary
Implements #23 (closed) and fixes #24 (closed)
For #23 (closed)
The ProtoMessageWrapper has been refactored into an abstract base class for RepeatedPtrFieldWrapper and ScalarProtoMessageWrapper, which implement the ToString methods. Effectively this means that now Parent, Parents, Property, Properties, Message, Messages, DataType, Value, ScalarValue (and probably some more) classes have the ToString method.
For #24 (closed)
The problem was that the Value's collection_value member has not been overridden, when the Value itself has been overridden.
This has been fixed by initializing a fresh instance of Value and by resetting the collection_value member in the assignment operators.
This problem most likely affected the DataType as well (and should be fixed by now).
Focus
For #24 (closed)
- Resets the collection_value: !25 (diffs)
- Initialize new DataType !25 (diffs)
- Initialize new Value !25 (diffs)
For #23 (closed)
Everything else is for #23 (closed).
Test Environment
- unit tests have been written.
- the cppinttest dev branch works for this as well
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
- All automated tests pass
- Reference related Issues
- Up-to-date CHANGELOG.md
-
Annotations in code (Gitlab comments)
- Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
- I understand the intent of this MR
- All automated tests pass
- Up-to-date CHANGELOG.md
- The test environment setup works and the intended behavior is reproducible in the test environment
- In-code documentation and comments are up-to-date.
- Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.