Skip to content
Snippets Groups Projects

F cpp to string

Merged F cpp to string
f-cpp-to-string into dev
All threads resolved!
Merged Timm Fitschen requested to merge f-cpp-to-string into dev
All threads resolved!

Summary

Implements #23 (closed) and fixes #24 (closed)

For #23 (closed)

The ProtoMessageWrapper has been refactored into an abstract base class for RepeatedPtrFieldWrapper and ScalarProtoMessageWrapper, which implement the ToString methods. Effectively this means that now Parent, Parents, Property, Properties, Message, Messages, DataType, Value, ScalarValue (and probably some more) classes have the ToString method.

For #24 (closed)

The problem was that the Value's collection_value member has not been overridden, when the Value itself has been overridden.

This has been fixed by initializing a fresh instance of Value and by resetting the collection_value member in the assignment operators.

This problem most likely affected the DataType as well (and should be fixed by now).

Focus

For #24 (closed)

  1. Resets the collection_value: !25 (diffs)
  2. Initialize new DataType !25 (diffs)
  3. Initialize new Value !25 (diffs)

For #23 (closed)

Everything else is for #23 (closed).

Test Environment

  • unit tests have been written.
  • the cppinttest dev branch works for this as well

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen
  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Florian Spreckelsen added 1 commit

    added 1 commit

    • e89fc870 - ENH: Add IsUndefined to datatypes in extern c

    Compare with previous version

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen approved this merge request

    approved this merge request

  • Timm Fitschen marked this merge request as ready

    marked this merge request as ready

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen requested review from @florian

    requested review from @florian

  • Timm Fitschen mentioned in commit ae012ce1

    mentioned in commit ae012ce1

  • Timm Fitschen merged

    merged

    • Please register or sign in to reply