ENH: New functions getEnumNameFromValue() and getEnumValueFromName()

Summary

See title.

Focus

Do the new functions cover the use cases of higher-order client libraries?

Test Environment

make test, look into test_utility.cpp.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass -> Please run clang-format on a more recent version than available here.
• Reference related Issues -> No explicit issue
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosdb/utility.cpp

@@ -63,7 +63,7 @@ auto getEnumValueFromName<Importance>(const std::string &name) -> Importance {
   //                         caosdb::entity::importance_names.cend(),
   //                         [name](const auto& entry){ return entry.second == name; });
   // Workaround: plaint old iteration:
-  for (auto entry: caosdb::entity::importance_names) {
+  for (auto const &entry: caosdb::entity::importance_names) {
     if (entry.second == name) {
       return entry.first;
     }
@@ -73,16 +73,17 @@ auto getEnumValueFromName<Importance>(const std::string &name) -> Importance {
 
 template <>
 auto getEnumValueFromName<AtomicDataType>(const std::string &name) -> AtomicDataType {
-  for (auto entry: caosdb::entity::atomicdatatype_names) {
+  for (auto const &entry: caosdb::entity::atomicdatatype_names) {
     if (entry.second == name) {
       return entry.first;
     }
   }
   throw std::out_of_range(std::string("Could not find enum value for string '") + name + "'.");
 }
+
 template <>
 auto getEnumValueFromName<Role>(const std::string &name) -> Role {
-  for (auto entry: caosdb::entity::role_names) {
+  for (auto const &entry: caosdb::entity::role_names) {
     if (entry.second == name) {
       return entry.first;
     }