Skip to content
Snippets Groups Projects

ENH: New functions getEnumNameFromValue() and getEnumValueFromName()

Merged Daniel Hornung requested to merge f-enum-utilities into f-consolidation

Summary

See title.

Focus

Do the new functions cover the use cases of higher-order client libraries?

Test Environment

make test, look into test_utility.cpp.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass -> Please run clang-format on a more recent version than available here.
  • Reference related Issues -> No explicit issue
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 67522b83 - ENH: Convenient list constructor for DataType.

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • f4ed997d - ENH: Convenience list argument for SetDataType(..., bool list_type).

    Compare with previous version

  • added 4 commits

    Compare with previous version

  • added 1 commit

    • 91220699 - STY: Use references in for loops and a lot of whitespaces

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • added 1 commit

    • 52081b05 - FIX: Trigger Int Tests in dev if there is no matching f branch

    Compare with previous version

  • Daniel Hornung added 2 commits

    added 2 commits

    • bc673d29 - 1 commit from branch f-consolidation
    • a5b1719b - Merge remote-tracking branch 'origin/f-consolidation' into f-enum-utilities

    Compare with previous version

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen enabled an automatic merge when the pipeline for a5b1719b succeeds

    enabled an automatic merge when the pipeline for a5b1719b succeeds

  • mentioned in commit 51f202ec

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading