jsex / yaml parser

Summary

• More descriptions everywhere.
• Fixed bug in get_deep: properties may be used multiple times
• Cleanup in yaml parser: list data types, property names
• Better mocks in jsex tests
• New yaml parser test for property inheritance

Focus

Mostly: Compatibility with previous use cases.

Test Environment

Run unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues caosdb/customers/dimr/management#114
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosadvancedtools/json_schema_exporter.py

@@ -245,11 +245,11 @@ class JsonSchemaExporter:
                 prop_name = prop.datatype
                 if isinstance(prop.datatype, db.Entity):
                     prop_name = prop.datatype.name
-                if prop_name in self._do_not_retrieve:
+                if prop.name in self._do_not_retrieve:
                     values = []
                 else:
                     values = self._retrieve_enum_values(f"RECORD '{prop_name}'")
-                if prop_name in self._do_not_create:
+                if prop.name in self._do_not_create:
                     # Only a simple list of values
                     json_prop["enum"] = values
                 else: