Skip to content
Snippets Groups Projects

jsex / yaml parser

Merged Daniel Hornung requested to merge f-more-jsonschema-export into dev
All threads resolved!

Summary

  • More descriptions everywhere.
  • Fixed bug in get_deep: properties may be used multiple times
  • Cleanup in yaml parser: list data types, property names
  • Better mocks in jsex tests
  • New yaml parser test for property inheritance

Focus

Mostly: Compatibility with previous use cases.

Test Environment

Run unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues caosdb/customers/dimr/management#114
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Pipeline #44130 passed

Pipeline passed for b5660e94 on f-more-jsonschema-export

Approval is optional

Merged by Florian SpreckelsenFlorian Spreckelsen 1 year ago (Nov 24, 2023 5:13pm UTC)

Loading

Pipeline #44182 passed

Pipeline passed for 06a3d145 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung requested review from @florian

    requested review from @florian

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    • e6a13890 - FIX: jsex: Better do_not_create

    Compare with previous version

  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung added 1 commit

    added 1 commit

    • 90570a20 - DOC: jsex: Better docstring, a few new TODOs

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • added 3 commits

    • 1506041f - 1 commit from branch dev
    • 117ae3a8 - Merge branch 'dev' into f-more-jsonschema-export
    • b5660e94 - FIX: Correct usage of ui inline in unittest

    Compare with previous version

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen approved this merge request

    approved this merge request

  • Florian Spreckelsen enabled an automatic merge when the pipeline for b5660e94 succeeds

    enabled an automatic merge when the pipeline for b5660e94 succeeds

  • mentioned in commit 06a3d145

  • Please register or sign in to reply
    Loading