f xlsimporter error

Summary

Fixes #52 (closed)

Focus

After trying to read a file without a proper ending, the pandas.io.excel.ExcelFile function throws a ValueError. I think, the XLRDError is thrown if a broken xls file is present, but with a correct ending.

Test Environment

I used pytest.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosadvancedtools/table_importer.py

@@ -182,7 +182,7 @@ class XLSImporter(object):
         """
         try:
             xls_file = pd.io.excel.ExcelFile(filename)
-        except XLRDError as e:
+        except (XLRDError, ValueError) as e:
             logger.warning(
                 "Cannot read \n{}.\nError:{}".format(filename,
                                                      str(e)),