Skip to content
Snippets Groups Projects

f xlsimporter error

Merged Alexander Kreft requested to merge f-xlsimporter-error into dev
All threads resolved!

Summary

Fixes #52 (closed)

Focus

After trying to read a file without a proper ending, the pandas.io.excel.ExcelFile function throws a ValueError. I think, the XLRDError is thrown if a broken xls file is present, but with a correct ending.

Test Environment

I used pytest.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Kreft

Merge request reports

Pipeline #13981 passed

Pipeline passed for 4358393c on f-xlsimporter-error

Merged by Henrik tom WördenHenrik tom Wörden 3 years ago (Oct 1, 2021 4:29pm UTC)

Merge details

  • Changes merged into with 289f60fe.
  • Deleted the source branch.

Pipeline #14367 passed with warnings

Pipeline passed with warnings for 289f60fe on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Kreft resolved all threads

    resolved all threads

  • mentioned in commit 289f60fe

  • Please register or sign in to reply
    Loading