Fix pylint errors
Summary
Fix pylint warnings and errors.
Addresses https://gitlab.indiscale.com/caosdb/customers/f-fit/management/-/issues/98
Focus
- Parameter with a dict as default were rewritten to not share their default value. Was this in error in any case?
- All
BaseExceptionswere replaced withException, as none of them seemed to need to catch SystemErrors and KeyboardInterrupts etc., was that mistaken anywhere? - To preserve current behaviour, all orphaned
excepts were given afrom e. Is there any case where this should have beenfrom None?
Test Environment
Manual Tests
Check List for the Author
-
All automated tests pass (locally only) -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
Annotations in code (Gitlab comments)
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
Edited by Daniel Hornung
Merge request reports
Activity
assigned to @i.nueske
added 1 commit
- 297530b1 - MNT: Ignore pylint errors for which issues have been created.
mentioned in merge request caosdb-pylib!170 (merged)
added 4 commits
-
297530b1...ef70481e - 3 commits from branch
dev - 8ce04d88 - Merge branch 'dev' into f-fix-linter-errors
-
297530b1...ef70481e - 3 commits from branch
Please register or sign in to reply