Skip to content
Snippets Groups Projects

Correct labels in yaml model parser

Merged Correct labels in yaml model parser
f-correct-labels into dev
2 unresolved threads
Merged Alexander Schlemmer requested to merge f-correct-labels into dev
2 unresolved threads

Summary

This is a correction for #77 (moved).

Test Environment

There is a unit test.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Pipeline #57498 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for 865aa265 on f-correct-labels

Merged by Henrik tom WördenHenrik tom Wörden 4 months ago (Nov 12, 2024 11:26am UTC)

Merge details

  • Changes merged into with 178c434c.
  • Deleted the source branch.

Pipeline #57596 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for 178c434c on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/caosadvancedtools/models/data_model.py
145 145 else:
146 146 query = db.Query(f"FIND ENTITY with id={ent.id}")
147 147 ref = query.execute(unique=True)
148 diff = (describe_diff(*compare_entities(ent, ref
149 ), name=ent.name))
148 diff = (describe_diff(*compare_entities(ent, ref),
  • Alexander Schlemmer
    Alexander Schlemmer @salexan started a thread on the diff
    • unittests/test_yaml_model_parser.py
    641 645 </RecordType>
    642 646 , 'bar': <RecordType name="bar"/>
    643 647 }"""
    648
    649
    650 def test_sync_output(capfd):
  • Alexander Schlemmer mentioned in issue #77 (moved)

    mentioned in issue #77 (moved)

  • Alexander Schlemmer
    Alexander Schlemmer @salexan ·
    Author Owner

    Pipeline failed wegen noch nicht gemergetem MR in pylib.

  • Alexander Schlemmer marked this merge request as ready

    marked this merge request as ready

  • Alexander Schlemmer added 7 commits

    added 7 commits

    Compare with previous version

  • Henrik tom Wörden added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden mentioned in commit 178c434c

    mentioned in commit 178c434c

  • Henrik tom Wörden merged

    merged

    • Please register or sign in to reply