WIP: XLSX converter errors.

src/caosadvancedtools/table_json_conversion/convert.py

@@ -54,9 +54,9 @@ def _column_id_to_chars(num):
     return _column_id_to_chars(int(num / 26) - 1) + chr(int(num % 26) + 65)
 
 
-def _format_exception_table(exceptions: list(tuple), worksheet_title: str,
-                            column_names: Optional[dict, list] = None,
-                            max_line_length: Optional[int] = 120) -> str:
+def _format_exception_table(exceptions: list[tuple], worksheet_title: str,
+                            column_names: Optional[Union[dict, list]] = None,
+                            max_line_length: int = 120) -> str:
     """
     Given a list of tuples containing a row and column number as well as an
     exception in that order, and the title of the current worksheet, returns
@@ -77,7 +77,7 @@ def _format_exception_table(exceptions: list(tuple), worksheet_title: str,
                         column_names[column_num] should return the name of
                         column column_names.
                         If given, exceptions will be clustered by column.
-    max_line_length:    int
+    max_line_length:    int, default=120
                         Soft cap for the line length of the resulting table
 
     Return
@@ -382,7 +382,7 @@ class XLSXConverter:
                     raise
                 self._errors[(sheet.title, row_idx)] = kerr.definitions
 
-        if exceptions != []:
+        if exceptions:
             exception_table = _format_exception_table(exceptions, sheet.title,
                                                       col_names)
             raise jsonschema.ValidationError(exception_table)

unittests/table_json_conversion/test_read_xlsx.py

@@ -126,11 +126,14 @@ def test_wrong_datatype():
             assert "J7" in line
         if "1.5 is not of type 'integer'" in line:
             assert "K7" in line
+        if "1.2345 is not of type 'integer'" in line:
+            assert "K8" in line
     # No additional type errors
     if "is not of type 'boolean'" in str(caught.value):   # ToDo: Remove when boolean is fixed
         assert str(caught.value).count("is not of type") == 3
     else:
-        assert str(caught.value).count("is not of type") == 2
+        assert str(caught.value).count("is not of type") == 2  # FIXME when everything works as
+        #                                                      # expected, set correct number.
 
 
 def test_additional_column():