Skip to content
Snippets Groups Projects

XLSX-Konverter: Bessere Fehlermeldung bei inkorrektem Typ in Spalte, zusätzlicher Spalte

Merged I. Nüske requested to merge f-xlsx-converter-error-messages into dev
All threads resolved!

Summary

Type and Validation errors are now collected and formatted as a table. The error raised when there is an additional column not present in the schema now describes the problem. Addresses https://gitlab.indiscale.com/caosdb/customers/dimr/management/-/issues/251

Focus

  • Does this solution improve readability and error identification? (is it a 'better output'?)
  • Are all errors covered?

Test Environment

Manual testing.

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?
Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I. Nüske
  • I. Nüske added 1 commit

    added 1 commit

    • a6910d39 - MNT: Added a warning when column metadata is not configured, and a better...

    Compare with previous version

  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske added 1 commit

    added 1 commit

    Compare with previous version

  • I. Nüske
  • I. Nüske marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • I. Nüske requested review from @daniel

    requested review from @daniel

  • added 1 commit

    Compare with previous version

  • I. Nüske added 1 commit

    added 1 commit

    • d0f4f3f5 - MNT: Implement review feedback, extend test, some more comments

    Compare with previous version

  • Daniel Hornung added 10 commits

    added 10 commits

    Compare with previous version

  • added 1 commit

    • 1a6a00ab - ENH: Even better error message.

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Daniel Hornung marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung mentioned in commit dccc2ce8

    mentioned in commit dccc2ce8

  • Please register or sign in to reply
    Loading