Skip to content
Snippets Groups Projects

Draft: Add tombstone delete

Open I. Nüske requested to merge f-tombstone into main
1 unresolved thread

Summary

Added tombstone delete to the Service and logs now differentiate between purge and delete.

This was tested against the GWDG Cordra instance and not the testbed. Set to draft because while it passes the Pipeline, the changes depend on the SDK MR.

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Appropriate user and developer documentation for new code
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Appropriate user and developer documentation for new code
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
Edited by I. Nüske

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
278 278 properties:
279 279 operation:
280 280 type: string
281 enum: ["Op.Create", "Op.Delete"]
281 enum: ["Op.Create", "Op.Purge", "Op.Delete"]
  • Author Developer

    Strictly speaking, Purge is not an Operation. However, as delete and purge have very different outcomes, the log should probably indicate which was run. This was the easiest solution.

  • Please register or sign in to reply
  • I. Nüske marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • unassigned @i.nueske

  • Please register or sign in to reply
    Loading