Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
F
FDO Manager Service
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
fdo
FDO Manager Service
Commits
e35a1a86
Verified
Commit
e35a1a86
authored
8 months ago
by
Timm Fitschen
Browse files
Options
Downloads
Patches
Plain Diff
MAINT: add merge request template
parent
09ad31fd
No related branches found
No related tags found
No related merge requests found
Pipeline
#52917
passed
8 months ago
Stage: build
Stage: test
Stage: package
Stage: upload
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
.gitlab/merge_request_templates/Default.md
+41
-0
41 additions, 0 deletions
.gitlab/merge_request_templates/Default.md
with
41 additions
and
0 deletions
.gitlab/merge_request_templates/Default.md
0 → 100644
+
41
−
0
View file @
e35a1a86
# Summary
*
Insert a meaningful description for this merge request here: What is the new/changed behavior?
Which bug has been fixed? Are there related issues?
*
# Focus
*
Point the reviewer to the core of the code change. Where should they start reading? What should
they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the
specs, finding more corner cases, concrete questions)?
*
# Testing
*How to set up a test environment for manual testing? Is there any manual testing needed?*
# Check List for the Author
-
[ ] All automated tests pass
-
[ ] Reference related issues
-
[ ] Appropriate user and developer documentation for new code
-
How do I use the software? Assume "stupid" users.
-
How do I develop or debug the software? Assume novice developers.
-
[ ] Annotations in code (Gitlab comments)
-
Intent of new code
-
Problems with old code
-
Why this implementation?
# Check List for the Reviewer
-
[ ] I understand the intent of this MR
-
[ ] All automated tests pass
-
[ ] Appropriate user and developer documentation for new code
-
[ ] The test environment setup works and the intended behavior is reproducible in the test
environment
For further good practices have a look at
[
our review guidelines
](
https://gitlab.com/caosdb/caosdb/-/blob/dev/REVIEW_GUIDELINES.md
)
.
/assign me
/target_branch main
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment