Skip to content
Snippets Groups Projects

Draft: Tests for non-purge delete

Open Draft: Tests for non-purge delete
f-delete-tests into main
2 unresolved threads
Open I. Nüske requested to merge f-delete-tests into main
2 unresolved threads

Summary

Added tests for delete, removed some inter-test dependencies, small refactors.

Depends on SDK and Service changes.

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Appropriate user and developer documentation for new code
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Appropriate user and developer documentation for new code
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
Edited by I. Nüske

Merge request reports

Pipeline #56144 failed

Stage: test

Pipeline failed for 29697d48 on f-delete-tests

Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
manager_test/test_utils/management_util.py 0 → 100644
  • I. Nüske
    I. Nüske @i.nueske started a thread on the diff
    • manager_test/manager_fdo/test_create_fdo.py
    337 373 case 'profile':
    338 374 self._assert_service(url, attributes)
    339 375 case 'service':
    376 return # ToDo: Remove as soon as the service entry on
    377 # hdl.handle.net is updated
    340 378 assert "0.TYPE/DOIPServiceInfo" in attributes
    341 attributes = json.loads(attributes["0.TYPE/DOIPServiceInfo"])["attributes"]
    379 attributes = json.loads(
    380 attributes["0.TYPE/DOIPServiceInfo"])["attributes"]
    342 381 assert "ipAddress" in attributes
    343 382 assert "port" in attributes
    • Comment on lines 339 to 343
      I. Nüske
      I. Nüske @i.nueske ·
      Author Developer

      The return prevents the four checks after that from being run, because they always fail when run against the GWDG instances. If run against the testbed, it can be removed. As soon as the hdl.handle.net entry is updated, it needs to be removed. I added the skip instead of an xfail, as the external-create-fdo-checks tend to cover a lot of failures in fdo creation that cannot be detected with the other tests, and an xfail would hide those failures. If that is not a concern, an xfail would be the more appropriate solution.

    • Please register or sign in to reply
  • I. Nüske marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • I. Nüske unassigned @i.nueske

    unassigned @i.nueske

    • Please register or sign in to reply