Skip to content
Snippets Groups Projects

FEAT(sample_upload): Allow event names in registration, upload, and export

Merged Florian Spreckelsen requested to merge f-event-name into main
All threads resolved!

Summary

For https://gitlab.indiscale.com/caosdb/customers/glaz_awi/management/-/issues/388. Introduce event-name handling to sample registration, upload, and export.

Focus

Very similar to sample-name treatment, so essentially more of the same.

Test Environment

  • Register samples with event name and make sure that the column is in the csv
  • update a sample and set the event name
  • export a sample with an event with a name and make sure the name is exported correctly
  • change the name of the event and re-upload the exported file. Make sure that the name is updated correctly.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
  • Florian Spreckelsen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Florian Spreckelsen requested review from @henrik

    requested review from @henrik

  • added 2 commits

    • 9635a06a - 1 commit from branch main
    • 1bcc0dba - Merge branch 'main' into f-event-name

    Compare with previous version

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • mentioned in commit f2f6997d

  • Please register or sign in to reply
    Loading