F awi sams
-
Review changes -
-
Download -
Patches
-
Plain diff
Summary
For #1 (closed). Removes the dependencies on the specifics of the GEOMAR data model and makes things more configurable.
Focus
A lot of functionality is moved into small Python modules in scripting/bin/sample_helpers
. They should define a reasonable default behavior for the datamodel in models_and_helper_scripts/sample-management-datamodel.yml
and the AWI SAMS datamodel, and should be overwritten by files of the same name in a server profile's custom directory for customization.
Test Environment
So far, only manual testing.
Do round trips for:
-
Container registration, export, update -
Sample registration, export, update
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
- version 26292fed5a
- version 25399fda02
- version 24bded836d
- version 238f7beb3f
- version 2284933ee0
- version 21092be437
- version 20232ea812
- version 19e8009701
- version 18a447505b
- version 173d636dab
- version 167d04de0c
- version 151a9e1857
- version 140fbb980a
- version 135fa73e89
- version 12206daaef
- version 1116ab9c3d
- version 106cde3c31
- version 99e577d31
- version 8421f0ee2
- version 757ef07b1
- version 60cadc8df
- version 56615797a
- version 49f0ecc0e
- version 3fe4d2ca4
- version 2c0d0740d
- version 1e145e16c
- main (base)
- latest version715a808563 commits,
- version 26292fed5a62 commits,
- version 25399fda0261 commits,
- version 24bded836d60 commits,
- version 238f7beb3f59 commits,
- version 2284933ee057 commits,
- version 21092be43756 commits,
- version 20232ea81254 commits,
- version 19e800970153 commits,
- version 18a447505b52 commits,
- version 173d636dab51 commits,
- version 167d04de0c48 commits,
- version 151a9e185747 commits,
- version 140fbb980a46 commits,
- version 135fa73e8945 commits,
- version 12206daaef44 commits,
- version 1116ab9c3d43 commits,
- version 106cde3c3141 commits,
- version 99e577d3140 commits,
- version 8421f0ee237 commits,
- version 757ef07b136 commits,
- version 60cadc8df35 commits,
- version 56615797a34 commits,
- version 49f0ecc0e33 commits,
- version 3fe4d2ca432 commits,
- version 2c0d0740d31 commits,
- version 1e145e16c28 commits,
- Side-by-side
- Inline
There are no changes yet
No changes between version 1 and version 1