Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
R
RuQaD
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
caosdb
Software
FAIR Data Spaces
RuQaD
Commits
f7f85b58
Verified
Commit
f7f85b58
authored
7 months ago
by
Daniel Hornung
Browse files
Options
Downloads
Patches
Plain Diff
FIX: Miscellaneous changes for code review.
parent
713e3c47
No related branches found
No related tags found
1 merge request
!3
F qualitycheck trigger
Pipeline
#58368
passed with warnings
7 months ago
Stage: info
Stage: setup
Stage: style
Stage: test
Changes
1
Pipelines
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/ruqad/qualitycheck.py
+9
-4
9 additions, 4 deletions
src/ruqad/qualitycheck.py
with
9 additions
and
4 deletions
src/ruqad/qualitycheck.py
+
9
−
4
View file @
f7f85b58
...
...
@@ -117,8 +117,7 @@ out : bool
self
.
_download_result
(
job_id
=
job_id
,
target_dir
=
target_dir
)
except
self
.
CheckFailed
as
cfe
:
print
(
"
Check failed
"
)
from
IPython
import
embed
embed
()
breakpoint
()
check_ok
=
False
...
...
@@ -156,6 +155,7 @@ This deletes all the objects in the bucket.
for
name
in
zipf
.
namelist
():
if
name
.
endswith
(
"
.json
"
):
continue
if
upload
:
self
.
_upload
(
os
.
path
.
join
(
tmp
,
name
),
remove_prefix
=
tmp
)
def
_upload
(
self
,
filename
:
str
,
remove_prefix
:
Optional
[
str
]
=
None
):
...
...
@@ -178,7 +178,8 @@ remove_prefix : Optional[str]
target_filename
=
filename
if
remove_prefix
:
assert
filename
.
startswith
(
remove_prefix
)
if
not
filename
.
startswith
(
remove_prefix
):
raise
ValueError
(
f
"
{
filename
}
was expected to start with
{
remove_prefix
}
"
)
target_filename
=
filename
[
len
(
remove_prefix
):]
self
.
_s3_client
.
upload_file
(
filename
,
self
.
_bucketname
,
os
.
path
.
join
(
"
data
"
,
target_filename
))
...
...
@@ -233,6 +234,10 @@ remove_prefix : Optional[str]
raise
self
.
CheckFailed
(
result
)
# Get jobs.
# We expect that these jobs are run runby the pipeline:
# - evaluate: run the quality check
# - report: build the report
# - pages: publish the report (not relevant for us)
cmd
=
[
"
curl
"
,
"
--header
"
,
f
"
PRIVATE-TOKEN:
{
self
.
_config
[
'
gitlab_api_token
'
]
}
"
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment