Skip to content

Upgrade to API version 2

Henrik tom Wörden requested to merge f-v2 into main

Summary

Upgrade to new APi and create a more wholistic cfood that is tested.

Focus

Items and experiments in eLabFTW are very similar. They are (basically/currently) the same in the cfood.

https://gitlab.indiscale.com/caosdb/customers/3dmmto/management/-/issues/31

Test Environment

unittest and please test manually:

  1. use the profile to start a LinkAhead instance
  2. Login to https://demo.elabftw.net
  3. Click on an experiment
  4. Click on the download icon and choose json
  5. Store the json in a file
  6. login to your linkahead instance
  7. click on the import button in the import menu
  8. upload the json
  9. verify that it looks good and that the url leads back to the same experiment
  10. do the same for an item
  11. You may use the /experiments/?limit=5 resource to get a JSON that contains multiple experiments
  12. Insert this json (Note, due to a bug, there is no url to the entry in elabftw)
  13. try the same for items.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary) unreleased
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading