Skip to content

F form helpers

Florian Spreckelsen requested to merge f-form-helpers into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/umg/management/-/issues/72. Create API functions to make HTML elements for form modals with which SSS are triggered.

Focus

Just copied existing code from customer projects to form_elements.js. Also use the new functions in ext_trigger_crawler.js.

Test Environment

Make sure that the unit test for ext_trigger_crawler.js still passes.

For manual testing, use, e.g., the caosdb-ekfs profile in local-s3-button. Make sure that the crawler forms still work as before.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports