Skip to content

F fix linkify preview

Florian Spreckelsen requested to merge f-fix-linkify-preview into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/182. Fixes a bug in linkify whereby an additional URL would be appended for every time a preview of a referenced entity was loaded.

Focus

Simply introduced a new css class caosdb-v-property-linkified to denote the properties that have been linkified already.

Test Environment

Manual testing only, since the bug requires the firing of the previewReadyEvent to occur.

Follow the steps to reproduce https://gitlab.com/caosdb/caosdb-webui/-/issues/199 and verify that the bug doesn't occur anymore. Also add an URL to the referenced entity. Feel free to play around with more than one referenced entity, more than one URL property, list of URLs, editting, and whatever else you can come up with.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports