Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
caosdb-webui
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
caosdb
Software
caosdb-webui
Merge requests
!90
F citation cff
Code
Review changes
Check out branch
Open in Workspace
Download
Patches
Plain diff
Expand sidebar
Closed
F citation cff
f-citation-cff
into
dev
Overview
1
Commits
7
Pipelines
1
Changes
1
Closed
Alexander Schlemmer
requested to merge
f-citation-cff
into
dev
2 years ago
Overview
1
Commits
7
Pipelines
1
Changes
1
Adding a citation.cff file, see:
https://citation-file-format.github.io/
0
0
Merge request reports
Viewing commit
5e16d05a
Prev
Next
Show latest version
1 file
+
14
−
1
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
5e16d05a
FIX: bottom line now also works for entities larger than viewport
· 5e16d05a
Alexander Schlemmer
authored
4 years ago
src/core/js/ext_bottom_line.js
+
14
−
1
View file @ 5e16d05a
Edit in single-file editor
Open in Web IDE
Show full file
@@ -68,6 +68,19 @@
* @requires ext_table_preview (module from ext_table_preview.js)
*/
/**
* Helper function analogous to ext_references isOutOfViewport
*
* Check whether the bottom of an entity is within the viewport.
* Returns true when this is the case and false otherwise.
*
*/
function
is_bottom_in_viewport
(
entity
)
{
var
bounding
=
entity
.
getBoundingClientRect
();
return
bounding
.
bottom
>
0
&&
bounding
.
bottom
<
(
window
.
innerHeight
||
document
.
documentElement
.
clientHeight
);
}
var
ext_bottom_line
=
function
(
$
,
logger
,
is_in_view_port
,
load_config
,
getEntityPath
,
connection
,
UTIF
,
ext_table_preview
)
{
/**
@@ -568,7 +581,7 @@ var ext_bottom_line = function($, logger, is_in_view_port, load_config, getEntit
BottomLineWarning
:
BottomLineWarning
,
}
}(
$
,
log
.
getLogger
(
"
ext_bottom_line
"
),
resolve_references
.
is
_in_viewport
_vertically
,
load_config
,
getEntityPath
,
is_bottom
_in_viewport
,
load_config
,
getEntityPath
,
connection
,
UTIF
,
ext_table_preview
);
Loading