Skip to content

F fsm

Timm Fitschen requested to merge f-fsm into dev

Summary

Entity State functionality for the webui.

  • A button which indicates the current state of an entity
  • A popover which shows information about the state let users start transitions

Focus

  • Displaying the entity state is handled in entity.xsl
  • The functionality (i.e. starting transitions) is handled in ext_entity_state.js
  • Note: the module patches the edit_mode by overriding the edit_mode.form_to_xml function. The patch uses a proxy pattern, where the old implementation is called internally, thus not interfering with other patches or changes in the original.

Test Environment

  1. Shoot up empty linkahead with the f-fsm branches for server, pylib and webui. Set server property EXT_ENTITY_STATE=ENABLED.
  2. Run misc/entity_state_test_data.py all against the linkahead instance.
  3. Go to the webui and play around with the state model

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports