Skip to content
Timm Fitschen requested to merge f-free-search-rt into dev

Summary

Implements #191 as per https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/151.

Also changes the behavior of the Enter key in the query form. From the Changelog:

New behavior of the "Enter" key in the query input text field: When pressed
when the autocompletion drop-down is open, the enter key selects an option
from the autocompletion (this is as it was before). But when the "Enter" key
is pressed, when the autocompletion drop-down is not open, the query is being
submitted.

Focus

  • By default, the new selector for the record type is disabled.
  • By default, the free text search now searches for "RECORD". Is that the desired behavior (the feature request seems to hold that)?
  • The handling of the "Enter" key is moved to the autocompletion module (which was the reason to change it from the default behavior of forms in the first place. So it belongs there anyways).

Test Environment

Please do test this manually. Try to follow the new documentation and let my know if something is missing.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports