Skip to content

F quotes googly search

Timm Fitschen requested to merge f-quotes-googly-search into dev

Summary

Focus

Splitting is done via "matchAll" and a property regex now. Note: white space is still the most important splitting character, so any terms enclosed by quotation marks will only be recognizes correctly when the quotation is enclosed by white spaces as well (and beginning and end of string, ofc).

Test Environment

Unit tests have been extended. However, please test manually as well.

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports