Skip to content

F dropdown

Timm Fitschen requested to merge f-dropdown into dev

Summary

"Fix" for #292 (closed)

Focus

The actual bug seems to be in the bootstrap-select library, which may be misusing the bootstrap 5 API. We cannot fix it easily, so we just ignore the error for now.

Also, I update bootstrap to the latest 5.2

Test Environment

Please also test this branch manually. Since #285 (closed) is yet unresolved, you might want to use the web console to make the dropdown menu visible by adding static height to the property line in the edit mode.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading