Skip to content

F google split at space

Florian Spreckelsen requested to merge f-google-split-at-space into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/97. The google search is enhanced s.th. the string in the query field is split at the spaces and then joined to an end query.

Focus

Added the splitting and joining to the corresponding function in webcaosdb.js

Test Environment

There's a new unit test that should be sufficient in principle. You can test it manually, e.g., by starting linkahead in the demo profile using this branch and sending a query like john gibson and verify that John Lennon's guitar is returned (since it has gibson in the description).

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports