Skip to content

bootstrap-select edit_mode

Timm Fitschen requested to merge f-style-dropdown-editmode into dev

Summary

caosdb/customers/leibniz-zmt/management#80

  • Use the nice bootstrap-select instead of plain html selects for all selects in the edit_mode.
  • Update bootstrap-select library to 1.14.0-beta3
  • cache query results in edit_mode for the values of the reference dropdowns.

Focus

The task here was: Find all selects and add the "selectpicker" class. Then find all the lines in the code where the select are being inserted into the dom tree and initialize the selects (otherwise, the class won't have any effect). So please try and find more select or places where the initialization is missing.

Test Environment

Please do a manual test because the styling is not testable with unit tests.

You can use misc/map_test_data.py to insert some entities. Then open the edit mode

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports