Skip to content
Snippets Groups Projects

F map list

Merged Timm Fitschen requested to merge f-map-list into dev

Summary

Map handles lists of references to entities with geolocations. See https://gitlab.com/caosdb/caosdb-webui/-/issues/172

Currently, all entities are shown as "collections" of geo-locations rather than paths, as per the requested feature. The path to the handling of paths is paved, tho.

Related: caosdb/customers/leibniz-zmt/management#55

Focus

  • Refactoring of getPropertyValues, _set_subprops_at_top and create_entity_markers which could not handle LIST-properties until now.
  • Minor changes add some quotation marks and parenthesis to the query-generation for more robustness.

Test Environment

For manual testing insert some test data with misc/map_test_data.py.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen added 1 commit

    added 1 commit

    • f289b9ab - DOC: update docstring ext_map.js

    Compare with previous version

  • Timm Fitschen
  • Timm Fitschen
  • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Timm Fitschen requested review from @florian

    requested review from @florian

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading