Skip to content

MAINT: Rename default person reference resolver

Florian Spreckelsen requested to merge f-rename-person-resolver into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/43. Simply renames the former person_resolver module to caosdb_default_person_resolver in order to prevent name conflicts with custom code.

Focus

Check whether it is renamed at all occurrences

Test Environment

Check on any instance with an RT Person with firstname and lastname properties. You may also verify that there are no name conflicts anymore in ZMT's server profile in local-map_person_resolver.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports