Skip to content
Snippets Groups Projects

MAINT: Rename default person reference resolver

Merged Florian Spreckelsen requested to merge f-rename-person-resolver into dev
All threads resolved!

Summary

For https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/43. Simply renames the former person_resolver module to caosdb_default_person_resolver in order to prevent name conflicts with custom code.

Focus

Check whether it is renamed at all occurrences

Test Environment

Check on any instance with an RT Person with firstname and lastname properties. You may also verify that there are no name conflicts anymore in ZMT's server profile in local-map_person_resolver.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Pipeline #21083 passed

Pipeline: LinkAhead

#21084

    Pipeline passed for 8402796f on f-rename-person-resolver

    Approval is optional

    Merged by Florian SpreckelsenFlorian Spreckelsen 3 years ago (Mar 31, 2022 8:41am UTC)

    Loading

    Pipeline #21721 passed

    Pipeline: LinkAhead

    #21722

      Pipeline passed for 0455ea7f on dev

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Florian Spreckelsen requested review from @timm

      requested review from @timm

    • Florian Spreckelsen requested review from @daniel and removed review request for @timm

      requested review from @daniel and removed review request for @timm

    • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

      marked the checklist item I understand the intent of this MR as completed

    • Daniel Hornung marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Daniel Hornung added 1 commit

      added 1 commit

      • c2433355 - DOC MAINT: Whitespace cleanup in documentation.

      Compare with previous version

    • Daniel Hornung added 1 commit

      added 1 commit

      • 69aaa5a0 - MAINT: Moved `caosdb_default_person.js` reference resolver to `core`.

      Compare with previous version

    • Daniel Hornung resolved all threads

      resolved all threads

    • Daniel Hornung
    • Daniel Hornung
    • Daniel Hornung added 1 commit

      added 1 commit

      • 8402796f - FIX: Added person resolver to MODULE_DEPENDENCIES

      Compare with previous version

    • Daniel Hornung
    • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

      marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

      marked the checklist item In-code documentation and comments are up-to-date. as completed

    • Daniel Hornung marked the checklist item All automated tests pass as incomplete

      marked the checklist item All automated tests pass as incomplete

    • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

      marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    • Daniel Hornung marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Daniel Hornung approved this merge request

      approved this merge request

    • Florian Spreckelsen resolved all threads

      resolved all threads

    • mentioned in commit 0455ea7f

    • Please register or sign in to reply
      Loading