Skip to content

ENH: Introduce css classes for required form fields

Florian Spreckelsen requested to merge f-style-form-elements into dev

Summary

In the course of https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/42, it was necessary to introduce additional css classes that can be styled individually.

Focus

Introduced new classes in form_elements.js and their default styling in webcaosdb.css.

Test Environment

Test with any instance that uses web forms (e.g., the demo profile) and verify that the old styling is still present with the new classes. You may use, e.g., Firefox's development tools to verify that the classes indeed can be styled.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports