Skip to content
Snippets Groups Projects

ENH: Add entity ids to label

Merged Florian Spreckelsen requested to merge f-ids-in-header into dev
All threads resolved!

Summary

See https://gitlab.indiscale.com/caosdb/customers/cfaed/management/-/issues/29. Adds the entity id to the entity label if a build variable is enabled.

Focus

Small addition in entity.xsl and an if-statement in webcaosdb.js that shows the ids when the build variable is enabled.

Test Environment

Verify that no ids are shown by default. Then, verify that they are when using BUILD_MODULE_SHOW_ID_IN_LABEL=ENABLED.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    • 03592842 - FIX: Show ID also for elements which come later.

    Compare with previous version

  • Daniel Hornung resolved all threads

    resolved all threads

  • mentioned in commit ddf23ee6

  • Please register or sign in to reply
    Loading