Skip to content
Snippets Groups Projects

FIX: Save WYSIWYG saving in source mode

Merged Florian Spreckelsen requested to merge f-wysiwyg-source-saving into dev
All threads resolved!

Summary

See https://gitlab.indiscale.com/caosdb/customers/cfaed/management/-/issues/36. This fixes a bug whereby changes made in Source Mode of the WYSIWYG editor would not be saved.

Focus

Instead of listening to CKEditor's change:data event, we're now using the edit mode's state machine and its insert and update transitions to update the text areas that were replaced by the WYSIWYG editor.

Test Environment

Start any CaosDB server with the BUILD_MODULE_EXT_EDITMODE_WYSIWYG_TEXT build property enabled. Verify that changes made in a text property using the WYSIWYG editor are now saved correctly both within and outside Source Editing after clicking save. Also test this with records that have multiple text properties.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
  • Florian Spreckelsen
  • Florian Spreckelsen
  • Florian Spreckelsen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Florian Spreckelsen requested review from @daniel

    requested review from @daniel

  • added 5 commits

    Compare with previous version

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung mentioned in commit 7f4b3fbe

    mentioned in commit 7f4b3fbe

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Please register or sign in to reply
    Loading