Skip to content

ENH: Add all query results to bookmarks

Florian Spreckelsen requested to merge f-add-query into dev

Summary

See https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/15. Adds a button to add all query results to bookmarks if the corresponding build variable is enabled (disabled by default).

Focus

Changes mainly concern the new functions in ext_bookmarks.js.

Test Environment

Parts can be unit tested (mainly getting the correct SELECT query from an arbitrary query string). For everything else, use this WebUI branch and enable BUILD_MODULE_EXT_ADD_QUERY_TO_BOOKMARKS build variable. Then execute different queries (FIND, COUNT, SELECT, with and without nasty special characters, ...) and see whether all new entities are added correctly.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports