Skip to content

qrcode

Timm Fitschen requested to merge f-qrcode into dev

Summary

Add a button which shows a QR-Code to the entity.

https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/22

Focus

  • QR-Code generation comes from the third-party library "https://github.com/soldair/node-qrcode" (1.4.4)
  • Not related to this MR: I noticed that there have been duplicate methods (getEntityId and getEntityID). I removed the former because the latter is used more frequently.

Test Environment

Manual testing doesn't require any special setup, just create an entity with the edit_mode.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports